Central management status added - #337
Merged
SuperQ merged 7 commits intoNov 14, 2025
Merged
Conversation
Signed-off-by: Örnfeldt Philip (66140321) <philip.ornfeldt@forsakringskassan.se>
SuperQ
requested changes
Oct 21, 2025
SuperQ
left a comment
SuperQ
left a comment
Contributor
There was a problem hiding this comment.
These would be better as state set / enum metrics.
SuperQ
reviewed
Nov 11, 2025
Sorry missed that Co-authored-by: Ben Kochie <superq@gmail.com> Signed-off-by: Philip Örnfeldt <1583206+Philldomd@users.noreply.github.com>
Contributor
|
Needs a rebase with the README.md |
SuperQ
approved these changes
Nov 11, 2025
SuperQ
left a comment
SuperQ
left a comment
Contributor
There was a problem hiding this comment.
I still prefer state sets for multi-value status gauges. But this is probably fine for now.
Contributor
Author
|
When you say state sets, do you mean one metrics per status? So registrationStatus should be divided to 4 metrics ? |
Contributor
|
Yes, a boolean per status with the status as a label is what we typically do for these kinds of metrics. Then you can do boolean PromQL like |
Signed-off-by: Philip Örnfeldt <philip.ornfeldt@outlook.com>
Philldomd
force-pushed
the
feature/system-central-management-status
branch
from
November 11, 2025 20:25
89e5ce3 to
8bc89ce
Compare
Signed-off-by: Örnfeldt Philip (66140321) <philip.ornfeldt@forsakringskassan.se>
rnxmlu
pushed a commit
to rnxmlu/fortigate_exporter
that referenced
this pull request
Feb 6, 2026
* Central management status added --------- Signed-off-by: Örnfeldt Philip (66140321) <philip.ornfeldt@forsakringskassan.se> Signed-off-by: Philip Örnfeldt <1583206+Philldomd@users.noreply.github.com> Signed-off-by: Philip Örnfeldt <philip.ornfeldt@outlook.com> Co-authored-by: Ben Kochie <superq@gmail.com> Signed-off-by: Michael Lucka <michael.lucka@rnetx.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Central management probe added